[fix] failed to save checkpoints in VideoLearner.fit()

microsoft / computervision-recipes

Best Practices, code samples, and documentation for Computer Vision.

MIT License

9.47k stars 1.17k forks source link

[fix] failed to save checkpoints in VideoLearner.fit() #609

Closed xueeinstein closed 4 years ago

xueeinstein commented 4 years ago

Description

Fix format bug of path string.

Failed to save checkpoints while training the model using video_learner.fit(save_model=True)

Related Issues

None

Checklist:

[ x] I have followed the contribution guidelines and code style for this project.
[x ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging and not master
[ ] I will squash merge this PR into staging

PatrickBue commented 4 years ago

Thanks for making this fix. I would approve, but the PR is made to master. Can you please make a PR to the "staging" branch instead? As per our contribution guidelines we only make code changes to staging, and update master in regular intervals.

xueeinstein commented 4 years ago

@PatrickBue Sure. I just close this PR and open a new one, #613