microsoft / confidential-sidecar-containers

This is a collection of sidecar containers that can be incorporated within confidential container groups on Azure Container Instances.
Other
28 stars 18 forks source link

Fixing SKR logging flags in SKR shell scripts #86

Closed ksayid closed 9 months ago

ksayid commented 9 months ago

A previous PR addressed a mismatch in flag names between docker/skr/skr.sh and cmd/skr/main.go, particularly concerning the -logfile and -loglevel flags. This mismatch prevented users from successfully running the SKR container when logging parameters were specified in their ARM templates.

This PR extends the fix to the remaining SKR shell scripts. The following changes were made:

  1. In docker/skr/skr-debug.sh, replaced -logFile ${LogFile} with -logfile ${LogFile} and -logLevel ${LogLevel} with -loglevel ${LogLevel}.
  2. In docker/skr/skr_test.sh, replaced -logFile ${LogFile} with -logfile ${LogFile} and corrected -port ${LogLevel} to -loglevel ${LogLevel}.