microsoft / containers-toolkit

Containers-Toolkit is a Windows PowerShell module for downloading, installing, and setting up default configs for Containerd, BuildKit, Windows CNI plugin, and nerdctl.
MIT License
14 stars 9 forks source link

Remove HNS automatic installation #28

Closed TinaMor closed 1 month ago

TinaMor commented 1 month ago

PR Description

Remove the automatic installation of the HNS module. Users must now install the HNS module manually, as it is not maintained or signed by Microsoft.

image

Issues:

  1. 23: re-use the nat network if exists?

TinaMor commented 1 month ago

LGTM, Haven't run it but just a check. For setup, does setup complete successfully and then just advise the user to do a manual HNS installation as follow-up?

We Write-Error to notify the user that the NAT network initialisation has failed. The error message contains a link to instructions on how to install HNS.