search

microsoft / containers-toolkit

Containers-Toolkit is a Windows PowerShell module for downloading, installing, and setting up default configs for Containerd, BuildKit, Windows CNI plugin, and nerdctl.
MIT License
16 stars 9 forks source link

fix: broken scripts #5

Closed fruzitent closed 7 months ago

fruzitent commented 7 months ago

fixes #4

d4pFFilgNP

Install-ContainerTools should call Install-*?

fruzitent commented 7 months ago

T3utSAKRBJ

all 93 tests are passing as well

TinaMor commented 7 months ago

Please squash commits

iankingori commented 7 months ago

Install-ContainerTools should call Install-*?

The Install-ContainerTools command does the most basic: (1) Uninstall the tools (2) Download the files (3) "Install" the tool.

This should be a quick setup. For more control, the user should use the Install-* commands. For example, if they want to register and start the containerd, they can't do that with Install-ContainerTools. They'll have to use Install-Containerd

@TinaMor does this mean Install-ContainerTools will not register the service? Can we add a switch to provide a Register-Service option

TinaMor commented 7 months ago

Can we add a switch to provide a Register-Service option?

Opened a new issue for tracking #7