microsoft / contosotraders-cloudtesting

The Contoso Traders app is a sample application showcasing Playwright, Azure Load Testing, Azure Chaos Studio.
https://cloudtesting.contosotraders.com
MIT License
159 stars 317 forks source link

Deployment instructions - make secret/variable formatting more clear #187

Closed annasoracco closed 1 year ago

annasoracco commented 1 year ago

Please update all secrets and variables to include the simple rule/requirement to creating secrets and variables that will pass GH checks -

  1. Format e.g. lower case only - or - Upper + Lower + number)
  2. Min/max number of characters
  3. Spacing or no spacing
  4. etc.
mithunshanbhag commented 1 year ago

Will fix.

mithunshanbhag commented 1 year ago

All GH secret values have already been updated.

Now updated the documentation as well in private branch. Will merge after code-review: https://github.com/microsoft/contosotraders-cloudtesting/commit/2698e64cdfdedb26ed1287cb37f1cf43fddcbfec