jacobg commented 5 years ago

cordova-plugin-file-transfer is deprecated and buggy (see #234). The plugin can be completely replaced with a standard-compliant implementation that works on Android >= 4.4 and iOS >= 10.

The Cordova team published a blog article last year explaining this transition: https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

Regarding the minimum required versions for the standard-compliant implementation, the latest version of Cordova Android platform already requires a minimum version of 4.4 (SDK 19). Source: https://cordova.apache.org/docs/en/latest/guide/platforms/android/

And Apple has announced that they will soon require all app submissions to target a minimum version of iOS 12:

Starting March 2019, all iOS apps submitted to the App Store will need to be built with the iOS 12.1 SDK or later. Source: https://developer.apple.com/ios/submit/

So it seems that cordova-plugin-code-push should transition off of cordova-plugin-file-transfer to a more modern and stable approach.

yuri-kulikov commented 5 years ago

Hi @jacobg, Thanks for the feedback!

Yes, it sounds pretty reasonable, we will add this item to our backlog and look at it in more detail. I can't say for sure when we solve this issue but we'll keep you posted.

bytenik commented 5 years ago

@yuri-kulikov Are you open to a pull request to resolve this?

yuri-kulikov commented 5 years ago

Hey @jacobg

Of course, we'll review it when we have time. We really appreciate it! 👍

bytenik commented 5 years ago

@yuri-kulikov Okay, a member of my team created this PR for you: https://github.com/Microsoft/cordova-plugin-code-push/pull/513

This should resolve this issue.

bytenik commented 5 years ago

@yuri-kulikov It appears your server is not set up correctly for CORS. Since there's no CORS header, XHR requests for the update package fail. Who can I escalate this to in order to get that addressed?

GuilleBarrena commented 5 years ago

How is this going? I have installed the latest version of the plugin "1.12.0" and it still uses FileTransfer plugin which is deprecated.

EvanWieland commented 4 years ago

Also having issues with this.

ermik commented 4 years ago

513 needs help from people familiar with the code base.

microsoft / cordova-plugin-code-push

Replace cordova-plugin-file-transfer with standard-compliant implementation #485

513 needs help from people familiar with the code base.