search

microsoft / coyote

Coyote is a library and tool for testing concurrent C# code and deterministically reproducing bugs.
https://microsoft.github.io/coyote/
Other
1.48k stars 76 forks source link

support net 8 #492

Closed WeihanLi closed 6 months ago

WeihanLi commented 9 months ago

try to support .NET 8

contributes to #491

pdeligia commented 9 months ago

Super helpful @WeihanLi, appreciate you opening this PR! Please give me a few days to find time to review & try this out, and we can try to merge ASAP!

pdeligia commented 9 months ago

By the way, just enabled the CI on this PR. Seems there are some build issues, if you are able to iterate when you have time, we can retry run it.

pdeligia commented 9 months ago

Also just in case it helps, this is last year's PR for upgrading to .NET 7, it should be pretty identical: https://github.com/microsoft/coyote/pull/439

WeihanLi commented 9 months ago

Should we drop the netcoreapp3.1 target since it's out of support now?

pdeligia commented 9 months ago

Should we drop the netcoreapp3.1 target since it's out of support now?

I would leave this target in for now, as AFAIK there are a few internal teams that still use it even if it's passed support as you say, can remove it at a later point.

WeihanLi commented 9 months ago

@pdeligia could you please help on the failed tests when you have a time, no idea why it failed 😭

pdeligia commented 9 months ago

@pdeligia could you please help on the failed tests when you have a time, no idea why it failed 😭

I will try to review this and let you know, but just a heads up that it is now unlikely before end of the year (due to really busy schedule this month wrapping up high priority items before the holiday season, and also freezing any code changes for this year). We can try to merge this in Jan. Thanks a lot for your contribution!

WeihanLi commented 9 months ago

Thanks very much

pdeligia commented 6 months ago

@WeihanLi I ended up upgrading coyote to .NET 8 as part of PR https://github.com/microsoft/coyote/pull/497 (I had to do some tweaks on your PR which was much easier to work on a fresh branch that I had write access to). For this reason I am closing your PR, thanks a lot for your effort!