search

microsoft / cpp_client_telemetry

1DS C++ SDK
Apache License 2.0
85 stars 48 forks source link

VS2022 support #1260

Open pablo-msft opened 1 month ago

pablo-msft commented 1 month ago

Add support for building in VS2022.

1ds only detects vs2017 or vs2019. So when installing packages, if vs2019 is installed the various packages must be installed in 2019 and not 2022.

maxgolov commented 1 month ago

Have you tried build-all-v143.bat:

https://github.com/microsoft/cpp_client_telemetry/blob/main/build-all-v143.bat

@echo off

set VSTOOLS_VERSION=vs2022
set PlatformToolset=v143
call build-all.bat

image

pablo-msft commented 1 month ago

Nice. I can use that.

That script is not documented anywhere, and the Windows documentation specifically does not make note of VS2022.

maxgolov commented 1 month ago

It's documented in README - Build issues are in general out of the support scope due to the unlimited number of build flags combinations.. https://github.com/microsoft/cpp_client_telemetry/pulls?q=is%3Apr+is%3Aclosed+vs2022 - if you feel that something is missing, best way to fix this is to send in a PR.

lalitb commented 1 month ago

@pablo-msft can this be closed ?

pablo-msft commented 1 month ago

@latitb I think this can be retitled, since VS2022 can be used, but should not be closed.

I acknowledge that build issues are out of support scope, due to consumers of the library using any combination of flags. However, there is a clear need for documentation of said flags or capabilities, so that new consumers can make informed decisions and use the capabilities of the 1DS library. Visual Studio is the tool that 1DS suggests using to compile its code package for Windows, and it is unclear how to configure it in the first place.