Compilation errors in MacOS 14.4.1 with 'Apple clang version 15.0.0'

microsoft / cpp_client_telemetry

1DS C++ SDK

Apache License 2.0

85 stars 48 forks source link

Compilation errors in MacOS 14.4.1 with 'Apple clang version 15.0.0' #1261

Open abuhsayem opened 1 month ago

abuhsayem commented 1 month ago

Describe your environment. MacOS 14.4.1

Steps to reproduce. Build 1DS SDK on latest MacOS 14.4.1

What is the expected behavior? No compilation errors

What is the actual behavior? Compilation error due to deprecated API (attached log) error: 'SCNetworkReachabilityCreateWithName' is deprecated: first deprecated in macOS 14.4 [-Werror,-Wdeprecated-declarations] build_error_mac.txt

Additional context. Add any other context about the problem here.

lalitb commented 1 month ago

@abuhsayem Thanks for reporting. SCNetworkReachabilityCreateWithName is used by 1DS SDK to detect the network type - whether the network connection is via WiFi, cellular, or wired Ethernet. We should be using nwpathmonitor for newer versions of iOS and MacOS. cc @absaroj @eduardo-camacho