search

microsoft / cpp_client_telemetry

1DS C++ SDK
Apache License 2.0
85 stars 48 forks source link

Crash in BondSplicer Splice #1263

Open jpalmaduran opened 1 month ago

jpalmaduran commented 1 month ago

Describe your environment.

SDK Version: 3.6.187.1 Platform: Windows OS Version: 10.0.22631.3296

Steps to reproduce. We don't have exact steps to reproduce, only stack traces

What is the expected behavior? Not to crash

What is the actual behavior? Random crashes,

image

Checking the value of the internal arrays

image

m_buffer has a length of 298643 bytes

image

The content of the packages would read beyond its length and crash.

writer.WriteBlob(m_buffer.data() + 298643, 7345).

Additional context. N/A

lalitb commented 3 weeks ago

This was discussed in the last community meeting. While the crash occurs during event encoding, as the library attempts to read beyond the allocated package size, but nothing wrong is seen by reviewing the relevant code. If the crash is consistently reproducible, please provide the exact steps to reproduce it or share the sample code that only depends on the 1ds-cpp-sdk.