search

microsoft / cpp_client_telemetry

1DS C++ SDK
Apache License 2.0
86 stars 49 forks source link

Java PAL layer need additional DDV APIs #493

Closed sid-dahiya closed 4 years ago

sid-dahiya commented 4 years ago

Before opening a feature request against this repo, consider whether the feature is generic enough for the SDK, or it should be a specific plugin/extension to the SDK.

Is your feature request related to a problem? We added additional APIs for DDV in #456 . They were made available in Obj-C and C++ layers.

Describe the solution you'd like. These APIs need to be added to Java as well.

Describe alternatives you've considered. NA, missing wrapper.

Additional context. NA.

maxgolov commented 4 years ago

Please also check what happens when the lib/modules is unavailable. Default decoder lives in modules. We used to assume that it's an optional additional component unique to office. Maybe we should reconsider the historic decision, and actually move the decoder into public, assuming you guys are ready to do this.. Practical reasons why this is relevant:

saurabh-sagrawal commented 4 years ago

Please also check what happens when the lib/modules is unavailable. Default decoder lives in modules. We used to assume that it's an optional additional component unique to office. Maybe we should reconsider the historic decision, and actually move the decoder into public, assuming you guys are ready to do this.. Practical reasons why this is relevant:

  • Edge-MMX now onboards to Android bits, but they use their own decoding strategy based off event callback in native code instead of remote DDV.
  • HoloLens SDK uses Android bits.
  • a few other apps too.. Depending on what strategy they take - local decoding or remote decoding - you may want to have some sort of write-up how the flow is structured in Office applications.

@sid-dahiya would be the right person to handle Max's request.