microsoft / cpp_client_telemetry

1DS C++ SDK
Apache License 2.0
85 stars 47 forks source link

Doxygen + index.md #696

Open maxgolov opened 3 years ago

maxgolov commented 3 years ago

We are publishing docs to GitHub pages. Currently there is no Index published, so there is no way to see the docs per se without knowing document name (which is hard to guess). While we work on OSS release, I think we need to add the following two things:

maxgolov commented 3 years ago

@reyang @mkoscumb

I have the following proposal for Doxygen:

That way we can guarantee that:

What I don't exactly like is checking-in the generated Markdowns. BUT - it gives us an easy way to compare the API, based on Doxygen-generated API docs. Because we have checked in the (prev) API docs, we can detect if the (curr) directory becomes unclean: changes after rerun of the Doxygen generator on a new PR, should someone touch / adjust the public API - we'd easily flag that.

It'll be both:

reyang commented 3 years ago

I've seen many GitHub projects publish docs to a separate branch (e.g. gh-pages) and set it as the branch for GitHub Pages.

My suggestion:

image

reyang commented 3 years ago

We might also explore if there is public API checker for C++. For C# we've been following the .NET practice, for example this one will be enabled upon GA https://github.com/open-telemetry/opentelemetry-dotnet/pull/806.

maxgolov commented 3 years ago

Another alternate branch for pages also makes sense.. if we consider alternate branch for docs though, these are the pros and cons:

lalitb commented 3 years ago

Using separate gh-pages branch to publish the automatically generated Github pages seems to be most popular way of publishing C++ documents. Found something similar for travisCI, but it should be easy to automate it using github action.