cpprest_compat breaks cURL header when building with Clang 14

microsoft / cpprestsdk

The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.

Other

7.99k stars 1.65k forks source link

cpprest_compat breaks cURL header when building with Clang 14 #1710

Open lilianmoraru opened 2 years ago

lilianmoraru commented 2 years ago

#define dllimport inside cpprest_compat.h breaks curl.h on Clang 14.

See minimized example here: godbolt

The issue was initially reported to LLVM. The LLVM issue was closed. For the reason, see these comments: comment1 and comment2.

barcharcraz commented 2 years ago

Yeah I can see why they closed that one. This header is pretty horrible.

laveur commented 1 year ago

FYI this project is now dead. You should move away from cpprest ASAP. See the readme file.

barcharcraz commented 1 year ago

Indeed, we will fix any super critical bugs, but we highly, highly, highly recommend folks move to another library. We usually recommend libcurl.