microsoft / cpprestsdk

The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.
Other
7.91k stars 1.64k forks source link

Fix likely typo in SafeInt3.hpp, that results in error with clang 15 #1711

Closed Fighter19 closed 1 year ago

Fighter19 commented 2 years ago

Please double check before merge. Prior to this, it resulted in following error while trying to build with the Emscripten toolchain.

[  1%] Building CXX object Release/src/CMakeFiles/cpprest.dir/http/client/http_client.cpp.o
In file included from /cpprestsdk/Release/src/http/client/http_client.cpp:16:
In file included from /cpprestsdk/Release/src/pch/stdafx.h:73:
In file included from /cpprestsdk/Release/include/cpprest/details/basic_types.h:31:
/cpprestsdk/Release/include/cpprest/details/SafeInt3.hpp:1577:32: error: parameter 'b' set but not used [-Werror,-Wunused-but-set-parameter]
    static void CastThrow(bool b, T& t) SAFEINT_CPP_THROW
blazorin commented 1 year ago

Thanks. This should be merged asap.

yuxiang-wen commented 1 year ago

收到,谢谢