Fix some UBs and memory leaks

microsoft / cpprestsdk

The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.

Other

7.89k stars 1.63k forks source link

Fix some UBs and memory leaks #1757

Open dimhotepus opened 1 year ago

dimhotepus commented 1 year ago

Do not leak clocale on _create_locale failed.
Add missed class member initializers to prevent UB on access to them.
Do not perform string -> char* -> string casts, use string directly.

Found by PVS-Studio https://pvs-studio.com/en/