microsoft / cppwinrt

C++/WinRT
MIT License
1.66k stars 239 forks source link

Add UTF-8 path support #1307

Closed kennykerr closed 1 year ago

kennykerr commented 1 year ago

This takes advantage of a Windows 10 manifest property to set the process code page to UTF-8.

Prior to this update:

cppwinrt.exe -in d:\Test❤️\Windows.winmd -out d:\Test❤️
cppwinrt : error Path 'd:\Test??\Windows.winmd' is not a file or directory

With this update:

D:\git\cppwinrt\_build\x86\Release\cppwinrt.exe -in d:\Test❤️\Windows.winmd -out d:\Test❤️

Input is parsed correctly and output is generated correctly.

I'm reluctant to add a test for this scenario to avoid complicating the build.

Fixes: #1306

kennykerr commented 1 year ago

@alvinhochun any suggestions for the Linux build failure?

alvinhochun commented 1 year ago

@alvinhochun any suggestions for the Linux build failure?

Looks like a random unrelated failure in that one test. I suspect a thread left over from another test just happened to interfere with it, perhaps?

kennykerr commented 1 year ago

Reran and it cleared - thanks for checking.