search

microsoft / cppwinrt

C++/WinRT
MIT License
1.64k stars 236 forks source link

Bug: linux hosted builds fail due to missing WinMD #1341

Closed jonwis closed 11 months ago

jonwis commented 1 year ago

Version

No response

Summary

1239 added use of a Windows.WinMD file from the windows-rs repo to help validate conformance of cppwinrt's output. https://github.com/microsoft/windows-rs/pull/2609/files?file-filters%5B%5D=.winmd&show-deleted-files=true&show-viewed-files=false# renamed the file in that repo, causing the existing curl ... command in our action to fail.

We should probably have our own copy of the WinMD as test collateral available in this repo. In an ideal world, we wouldn't rely on Windows.WinMD at all and instead use a local custom metaplatform.winmd, but that's not feasible due to heavy reliance on Windows.Foundation.* types, behaviors, and attributes. It is, after all, C++/Win[dows]RT.

Reproducible example

No response

Expected behavior

No response

Actual behavior

No response

Additional comments

No response

kennykerr commented 1 year ago

FYI @alvinhochun

kennykerr commented 1 year ago

I much prefer smaller discrete yml workflows (hence this collection) because then you can just disable individual workflows via the GitHub Actions UX.

kennykerr commented 1 year ago

I've also had to remove tests that rely on GNU to build in #1348 since their import libs don't include some Windows 8 exports.

Incidentally, this is one of the reasons why windows-rs generates its own import libs:

https://github.com/microsoft/windows-rs/tree/master/crates/targets

github-actions[bot] commented 12 months ago

This issue is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.