search

microsoft / cppwinrt

C++/WinRT
MIT License
1.64k stars 236 forks source link

Allows partial activation handling #1346

Closed CarlosNihelton closed 11 months ago

CarlosNihelton commented 1 year ago

With the suggested changes a test suite can handle only the activation it's interested in, leaving others for the default implementation, conventionally returning winrt::impl::error_not_implemented.

Fixes: #1345

kennykerr commented 1 year ago

winrt_activation_handler was added for the Shell team so I'll defer to @ChrisGuzak or @oldnewthing on whether this change is appropriate.

github-actions[bot] commented 11 months ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

CarlosNihelton commented 11 months ago

I guess we are done with this PR, right?!

kennykerr commented 11 months ago

Unfortunately, one of the @microsoft/cppwinrt-maintainers has not stepped up to own #1345 and steward this change. It looks like @oldnewthing / @Scottj1s may be interested, but I'm personally a little reluctant to add more low-level hooks as it adds complexity and unpredictability to an already complex activation process.

More info: https://github.com/microsoft/cppwinrt/blob/master/docs/contributing.md

CarlosNihelton commented 11 months ago

Well, thanks for the attention on this topic anyway! It was quite enlightening.