Bug: observable_map_base::call_changed is private

Patschkowski commented 1 week ago

Version

C++/WinRT v2.0.220110.5

Summary

Dear all,

winrt::observable_vector_base::call_changed is declared protected, while winrt::observable_map_base::call_changed is declared private.

Propose to change the latter to the way it is declared in the former.

Kind regard, Felix

Reproducible example

No response

Expected behavior

winrt::observable_map_base::call_changed should be possible to access from a derived class.

Actual behavior

Cannot access winrt::observable_map_base::call_changed from a derived class.

Additional comments

No response

kennykerr commented 1 week ago

@dunhor may be able to comment on visibility.

dunhor commented 1 week ago

Going based off source history, it looks like call_changed has existed since the very first commits; I did not add them. That aside, I don't see any reason why call_changed can't be protected in both types.

kennykerr commented 1 week ago

Ah, I may have written that after all. 😊

kennykerr commented 1 week ago

Feel free to offer a contribution.

microsoft / cppwinrt