fix: get pipeline by name not id in Data Factory and Synapse

microsoft / data-factory-testing-framework

A stand-alone test framework that allows to write unit tests for Data Factory pipelines on Microsoft Fabric, Azure Data Factory and Azure Synapse Analytics.

MIT License

88 stars 20 forks source link

fix: get pipeline by name not id in Data Factory and Synapse #98

Closed yehiaelbehery closed 6 months ago

yehiaelbehery commented 6 months ago

Use get_pipeline_by_name in the case of Data Factory or Synapse as they use the name not ID similar to Fabric.

arjendev commented 6 months ago

Hi @yehiaelbehery,

Could you explain why the current implementation is not working as expected? For Data Factory we set the pipeline_name as the pipeline_id in the deserializer, because names are unique in Data Factory and thus we can treat them as a pipeline_id.

Curious to hear your motivation!

yehiaelbehery commented 6 months ago

Hello @arjendev,

Mainly because there was a method called get_pipeline_by_name and the error message using "name". So I assumed this is the design. If it's not the design, I would still opt-in to use the separate function to document and express this difference between data factory and fabric implementation, which may impact other functionality.