search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
66 stars 14 forks source link

Render Datamations in Rmarkdown? #117

Closed jhofman closed 2 years ago

jhofman commented 2 years ago

@sharlagelfand, let's see if it "just works" to render a datamation in an html Rmarkdown document?

sharlagelfand commented 2 years ago

Yes, just works! 🎉 all good in an Rmd with html_document output (as we would expect to use, since it's HTML based).

The HTML file renders fine locally for me, but for some reason not in a github preview of the file - I'm not sure what the difference is! But it looks like @giorgi-ghviniashvili's test file doesn't render in the github preview either, even though it works locally!

giorgi-ghviniashvili commented 2 years ago

Hi @sharlagelfand , bunch of errors in the console, I don't know why:

image

Here d3 is missing and has problems with in operation, possible need polyfill?

image

jhofman commented 2 years ago

Amazing that it "just works"!

Seems like the github preview is a problem w/ htmlpreview.github.io.

I tried rawcdn.githack.com, an alternative, and it's working fine there. Hooray!

https://rawcdn.githack.com/microsoft/datamations/c33abbdd8654df1d3d6ccaaf84bdd444188068f6/sandbox/test_rmd.html

sharlagelfand commented 2 years ago

oh perfect! Crisis averted. I'll close this now, feel free to reopen if there's anything else!