search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 15 forks source link

Group by two columns #125

Closed chisingh closed 2 years ago

chisingh commented 2 years ago

Second example grouping by two columns. Closes #121

sharlagelfand commented 2 years ago

@chisingh there is a bit off with the specs when compared with the R specs - there should be a field sort in the facet encoding to ensure ordering, it's added e.g. here for the column facets. That line was added just a few weeks ago but it looks like your fork is out of date so the specs don't match. If you branch off microsoft/datamations directly instead of the fork it could be easier to ensure you have the latest changes?

Small request, could we move the test specs to inst/python_specs/ or somewhere else in inst? I didn't realize (but it makes sense) that because the datamations folder is ignored in the R package building process, the folder datamations/tests/specs isn't available when the package is checked and the tests are run on continuous integration - whoops!