search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
66 stars 14 forks source link

fix x label jitter between group-by grid and next frame for unequal sized groups #143

Closed jhofman closed 2 years ago

jhofman commented 2 years ago

sometimes when we have uneven sized groups and we go from infogrid to scatter plot, we see the x axis label jitter a bit. here's an example from 7 seconds to 10 seconds:

https://github.com/microsoft/datamations/issues/62#issuecomment-1063869253

let's try some alternatives for giving each group equal amounts of the x axis so that it lines up with the next frame.

giorgi-ghviniashvili commented 2 years ago

@jhofman this is how it would look if I gave same amount of space to each grid.

It will still have small axis shift, because of y axis (it appears on jitter only).

Also this might be a problem for case where we have many circles. They may overlap if too many points and each group has size equal to biggest group.

https://user-images.githubusercontent.com/6615532/158781624-0e5613d2-43d2-42ae-b95c-eff227a64b01.mov

P.S. ignore funky animation, it is fake data.

jhofman commented 2 years ago

okay @giorgi-ghviniashvili, i think this is step in the right direction so let's see how it goes with bigger groups.

also, a note to update the fake data you're using there to have the correct number of points for phd in the first frame. (right now it's a copy of the masters data, mistakenly).

giorgi-ghviniashvili commented 2 years ago

@jhofman no jump at all:

https://user-images.githubusercontent.com/6615532/159290996-e140588a-7619-4464-ade3-8fc99d0defaf.mov

jhofman commented 2 years ago

closes #148