search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
66 stars 14 forks source link

Pylint workflow failing #175

Closed chisingh closed 2 years ago

chisingh commented 2 years ago

Pylint workflow is enabled and currently failing:

https://github.com/microsoft/datamations/actions/runs/2417776739

LinqingZ commented 2 years ago

I found all the issues after running pylint, working on to fix the code.

***** Module datamations.datamation_frame datamation_frame.py:23:34: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:81:0: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:85:0: C0301: Line too long (104/100) (line-too-long)
datamation_frame.py:88:0: C0301: Line too long (103/100) (line-too-long)
datamation_frame.py:95:0: C0301: Line too long (125/100) (line-too-long)
datamation_frame.py:97:16: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:106:38: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:131:0: C0301: Line too long (149/100) (line-too-long)
datamation_frame.py:132:20: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:176:0: C0301: Line too long (193/100) (line-too-long)
datamation_frame.py:182:20: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:221:0: C0301: Line too long (108/100) (line-too-long)
datamation_frame.py:222:0: C0301: Line too long (105/100) (line-too-long)
datamation_frame.py:234:24: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:273:0: C0301: Line too long (265/100) (line-too-long)
datamation_frame.py:295:0: C0301: Line too long (103/100) (line-too-long)
datamation_frame.py:297:13: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:308:0: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:314:0: C0301: Line too long (194/100) (line-too-long)
datamation_frame.py:332:0: C0303: Trailing whitespace (trailing-whitespace) datamation_frame.py:334:0: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:335:17: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:347:67: C0303: Trailing whitespace (trailing-whitespace)
datamation_frame.py:1:0: C0114: Missing module docstring (missing-module-docstring) datamation_frame.py:11:0: E0401: Unable to import 'IPython.core.display' (import-error) datamation_frame.py:14:0: C0115: Missing class docstring (missing-class-docstring) datamation_frame.py:14:0: R0903: Too few public methods (1/2) (too-few-public-methods) datamation_frame.py:24:0: C0115: Missing class docstring (missing-class-docstring) datamation_frame.py:37:4: R0913: Too many arguments (6/5) (too-many-arguments) datamation_frame.py:38:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) datamation_frame.py:48:4: C0116: Missing function or method docstring (missing-function-docstring) datamation_frame.py:52:4: C0116: Missing function or method docstring (missing-function-docstring) datamation_frame.py:56:4: W0221: Number of parameters was 10 in 'DataFrame.groupby' and is now 2 in overridden 'DatamationFrame.groupby' method (arguments-differ) datamation_frame.py:57:27: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) datamation_frame.py:59:8: C0103: Variable name "df" doesn't conform to snake_case naming style (invalid-name) datamation_frame.py:59:13: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) datamation_frame.py:59:8: W0612: Unused variable 'df' (unused-variable) datamation_frame.py:63:4: C0116: Missing function or method docstring (missing-function-docstring) datamation_frame.py:122:12: W0622: Redefining built-in 'id' (redefined-builtin) datamation_frame.py:63:4: R0914: Too many local variables (24/15) (too-many-locals) ase naming style (invalid-name)datamation_frame.py:174:16: C0103: Variable name "id" doesn't conform to snake_case naming style (invalid-name)datamation_frame.py:267:16: C0103: Variable name "id" doesn't conform to snake_case naming style (invalid-name)datamation_frame.py:271:20: C0103: Variable name "id" doesn't conform to snake_case naming style (invalid-name)datamation_frame.py:309:12: C0103: Variable name "id" doesn't conform to snake_case naming style (invalid-name)datamation_frame.py:312:16: C0103: Variable name "id" doesn't conform to snake_case naming style (invalid-name)datamation_frame.py:63:34: W0613: Unused argument 'width' (unused-argument) datamation_frame.py:63:45: W0613: Unused argument 'height' (unused-argument)datamation_frame.py:63:4: R0912: Too many branches (37/12) (too-many-branches) datamation_frame.py:63:4: R0915: Too many statements (125/50) (too-many-statements)datamation_frame.py:322:4: C0116: Missing function or method docstring (missing-function-docstring)
datamation_frame.py:322:30: W0613: Unused argument 'width' (unused-argument) datamation_frame.py:322:41: W0613: Unused argument 'height' (unused-argument) datamation_frame.py:346:4: C0116: Missing function or method docstring (missing-function-docstring)
datamation_frame.py:350:4: C0116: Missing function or method docstring (missing-function-docstring)
datamation_frame.py:357:27: C0209: Formatting a regular string which could be a f-string (consider-using-f-string) datamation_frame.py:10:0: C0411: standard import "import json" should be placed before "import pandas as pd" (wrong-import-order) datamation_frame.py:11:0: C0411: third party import "from IPython.core.display import display, Javascript" should be placed before "from . import datamation_groupby" (wrong-import-order)

-----------------------------------Your code has been rated at 6.56/10