Closed giorgi-ghviniashvili closed 3 years ago
@jhofman Started working on this, but finding it hard to exactly match points:
Upper ones are real ones, below ones are faked.
Will need a bit more work on this.
@giorgi-ghviniashvili looks like a pretty good start, in fact i'm not sure what looks "off" other than the lower-left panel where the blue points are outside of the axes?
Points are duplicated, one point is from real faceted view, the other one is faked (a bit below). These two needs to match exactly and have only one circle, like this:
@jhofman made it work:
Two vega graphs are overlaid.
Inner axes is drawn using "vega spec for axis".
Outer axes done with fake faceted spec. Notice that because we are using fake faceted view we can have facet axis on the right, which would not be possible with real faceted view because it is not supported yet.
Will do animation now.
@giorgi-ghviniashvili this looks great! If I want to pass a title for the y-axis in the jitter/summary frames, does it make sense to just pass that through in the y encoding title
?
@sharlagelfand , yes I think it will work. Please also remove axis: null from spec you want additional axis, and add title to it.
Just to keep track of here, previously the axis appeared as soon as the points moved from infogrid -> jitter
But now it looks like they only appear when moving jitter -> summary
Probably better to keep them on for longer (the first case)
@giorgi-ghviniashvili as discussed yesterday, can you check and confirm that the bounding boxes of the real and fake axes line up?
@jhofman yes, currently they line up correctly (tested various frames).
As per @jhofman 's comment that points don't line up correctly:
@sharlagelfand could you please do this:
Avoid using decimals, and have 1, 2, 3 in axis.values
. Adjust padding using scale.domain
(and always include scale.domain
).
We will get this:
Thanks @giorgi-ghviniashvili!
I have a question about the Y domain in the jitter and summary frames - I've set the Y domain to be the range of the data as we discussed so that the summary points are in the same range as the jitter points. It all looks good in the animation but when you actually click on the last summary frame, you can see it has a different Y domain:
Do you know why the domain looks like this? The actual frame itself in the vega lite editor doesn't look like that:
In the specs here you can see that the Y domain is the same for the jitter and the summary frame - is there something going on with that final frame that changes its axis? Thanks!
@sharlagelfand good catch, fixed it. Please update shiny app with this commit.
Looks good, thanks @giorgi-ghviniashvili!
I got an idea to render two vega specs, one for axis and not touched by Gemini and second for fake faceted with animated by Gemini.