microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 14 forks source link

Axes and legend appearing too late #47

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

@giorgi-ghviniashvili just wanted to track here the issue that axes are appearing too late - they should appear as soon as the infogrid -> jitter transition starts, but they appear when jitter -> summary starts:

https://user-images.githubusercontent.com/15895337/118002420-975be800-b315-11eb-9427-469130e5cd81.mov

I also just noticed that the legend doesn't appear until jitter -> summary! Ideally it should appear as soon as the faceted infogrid starts to animate into the colored version. Maybe has to do with the fake axes and when those show up?

You can see this on the app with dataset: penguins and group by: species, island, sex

Thanks!

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand fixed it, please check it here.

sharlagelfand commented 3 years ago

thanks @giorgi-ghviniashvili, axes looks good! is it possible to fix the legend too?

giorgi-ghviniashvili commented 3 years ago

Whats wrong with the legend?

sharlagelfand commented 3 years ago

From my first comment :)

I also just noticed that the legend doesn't appear until jitter -> summary! Ideally it should appear as soon as the faceted infogrid starts to animate into the colored version. Maybe has to do with the fake axes and when those show up?

giorgi-ghviniashvili commented 3 years ago

Ah, fixed it now. I was setting legend to null for all case, but now I am setting to null if meta.axes.

sharlagelfand commented 3 years ago

Thanks @giorgi-ghviniashvili! In the video below is the legend moving positions due to have it from fake axes vs from real axes? Not sure what causes this

https://user-images.githubusercontent.com/15895337/118134736-40ffaf80-b3d0-11eb-8260-fae6a7203934.mov

giorgi-ghviniashvili commented 3 years ago

Fixed it! @sharlagelfand

sharlagelfand commented 3 years ago

looks good now @giorgi-ghviniashvili ty!!