microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 14 forks source link

Points moving across facets #48

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

@giorgi-ghviniashvili I haven't been able to figure out why points are moving across facets - as far as I can tell the IDs match! Could you take a look? The example in #47 shows it and also this one in the app with dataset: penguins and group by: species, island, sex:

https://user-images.githubusercontent.com/15895337/118013158-d1ca8280-b31f-11eb-8b5f-f82f1b8042b2.mov

The specs for this case are here.

Thanks!!

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand found one issue: Adelie and Torgersen has 5 NA points, while jitter one has 4:

image

sharlagelfand commented 3 years ago

@giorgi-ghviniashvili one of the Y values is actually NA (/null) so it shouldn't show up in the jittering - is it possible to have that point shown in the infogrid then "disappear" when move to jittering?

I have it worked out so the ID of the NA one isn't in the specs (here - there is id 147 and 149, but no 148 since that value is missing), but maybe that's not how gemini actually works - thought it might pick up the ID being gone between frames and fade it out?

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand it should work like you describe, the point with id 148 should be gone in exit selection of d3, but needs a bit more exploration why it does not work like that. Will dive into it.

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand I found the issue. The gemini's recommendations did not correctly generate the animation spec. I manually updated gem spec for third frame and got this:

https://user-images.githubusercontent.com/6615532/118154598-4d175b80-b428-11eb-86fa-0c00e9eb3297.mov

In general, I should come up with general solution.

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand It is not a bug with the gemini, but the initialization object (my fault!). I modified it and now it correctly recommends. It was not correctly setting gemini_id.

sharlagelfand commented 3 years ago

thank you!!! looks good 🎉