search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 14 forks source link

Look at gemini internals for fixes/enhancements #49

Open giorgi-ghviniashvili opened 3 years ago

giorgi-ghviniashvili commented 3 years ago

I think I should start reading gemini source code and see how it works to be able to fix some internal things. For example this.

Also #48 is related to gemini recommendations, which does not correctly gets recommended gemini animation spec. Would be better to a least debug and find why it does not work correctly.

For example, it always gets encode: { enter: true, exit: true, update: true }, even if I set them to false in options.

giorgi-ghviniashvili commented 3 years ago

update about #48, I was initializing recommendation options incorrectly. Fixed it now.

jhofman commented 3 years ago

we agreed that this is useful at some point, but it's a big investment in time. we'll hold off on this for now.