search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 14 forks source link

Angle x-axis labels so they're not cut off #58

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

Discussed already with @giorgi-ghviniashvili, but right now long x-axis labels are cut off (Dream isn't shown at all)

Screen Shot 2021-05-25 at 10 46 02 AM

We should either: pass the angle for the axis labels in the specs, or set them within JS to all have labelAngle = -90, so it looks more like this:

Screen Shot 2021-05-25 at 10 49 21 AM

I'm inclined to just have this handled on the JS side and always set them to -90

giorgi-ghviniashvili commented 3 years ago

I can set this in axis-layer's spec, but you can also send labelAngle within the spec.

sharlagelfand commented 3 years ago

Let's handle on the JS side for now so it's consistent - if we want it to be customizable by the user later on we can revisit sending it with the spec.

giorgi-ghviniashvili commented 3 years ago

Ok @sharlagelfand , done it: image

sharlagelfand commented 3 years ago

Thanks @giorgi-ghviniashvili! Which commit has this for me to copy over?

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand latest from branch gio/error-bars.

sharlagelfand commented 3 years ago

thanks, looks good!