microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 15 forks source link

Positioning of error bar div is off #63

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

Just keeping track of this separately from the other error bar issues, @giorgi-ghviniashvili looks like the positioning of the error bar div works when the widget is by itself but not when it's in the app (version live here with it), they don't show up (or are in the wrong place / offscreen?)

Screen Shot 2021-05-26 at 2 05 02 PM
giorgi-ghviniashvili commented 3 years ago

@sharlagelfand please update code from gio/error-bars branch and also don't forget to copy all the styles from gio/errorbars index.html.

sharlagelfand commented 3 years ago

@giorgi-ghviniashvili everything is updated, still in the wrong place.

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand , .hidden class is overridden by shiny's utilities styles and it is completely hidden... Will use different class, instead of hidden. For example: vega-hidden-layer.

Please update code from error-bars branch and it will be fixed.

sharlagelfand commented 3 years ago

Looks good, thanks!