search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 15 forks source link

Length of initial frame, not shown on replay #65

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

To keep track of, I think the initial frame should be shown longer - it only appears for a split second. And on "replay", the title for it does not appear at all - just goes straight into the group by:

https://user-images.githubusercontent.com/15895337/120004264-8ca38300-bfa4-11eb-9061-675dac26cb56.mov

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand yes, that's because we show description immediately the animation starts. Maybe I should draw first frame on replay and then have a bit of delay until animation starts?

sharlagelfand commented 3 years ago

Yeah, I think it would be helpful to "pause" on each of the frames (especially the first) during the animation, rather than animating immediately from frame to frame

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand added delay:

https://user-images.githubusercontent.com/6615532/120784003-ae6caf00-c53c-11eb-971c-beb724443683.mov

sharlagelfand commented 3 years ago

Thanks @giorgi-ghviniashvili! looks great to me

jhofman commented 3 years ago

looking good, quick question: at 10-11 seconds, are the points on the far right panel shifted to the right for some reason? they don't look centered around Adelie

giorgi-ghviniashvili commented 3 years ago

@jhofman I think I just fixed that.

giorgi-ghviniashvili commented 3 years ago

image