search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
66 stars 14 forks source link

Move shiny app into separate repo / package #71

Open sharlagelfand opened 3 years ago

sharlagelfand commented 3 years ago

Something for us to consider - with the Shiny app and the main package coupled, datamations depends on all of the packages that the Shiny app uses (current list is here). So if someone wanted to use datamations they'd need to also install shiny, shinyAce, shinywidgets, shinydashboard, shinyjs, etc etc... just to get their datamation!

It might make sense to move the shiny app into its own package or repo - I think this gets us a bit into #4 re: how repos are structured/hosted.

One way to approach this is how arrow does, with a single repo containing all of its different libraries, e.g. the r package is in the r/ subdirectory

giorgi-ghviniashvili commented 3 years ago

I like the idea of having one repository but have different libraries (directories) like arrow does.

jhofman commented 3 years ago

I agree, different subdirectories makes sense.

Let's check that something like devtools::install_github("microsoft/datamations") gets modified. Does it become devtools::install_github("microsoft/datamations/R"), if the R package is in an R/ subdir?

Also, how do the R and JS documentation sites get built?

sharlagelfand commented 2 years ago

I'm running into a lot of issues deploying the app when it's moved into a separate directory from the main datamations package! Not sure why, seems to be some issue with installing datamations onto shinyapps.io that I can't quite figure out. I think I'll take a pause from this (snooze it?) rather than continue labouring on trying to figure it out, and revisit in a bit!

jhofman commented 2 years ago

sgtm

On Fri, Jul 30, 2021 at 3:37 PM Sharla Gelfand @.***> wrote:

I'm running into a lot of issues deploying the app when it's moved into a separate directory from the main datamations package! Not sure why, seems to be some issue with installing datamations onto shinyapps.io that I can't quite figure out. I think I'll take a pause from this (snooze it?) rather than continue labouring on trying to figure it out, and revisit in a bit!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/microsoft/datamations/issues/71#issuecomment-890111583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATNS4AK7MKRDTLA3X7SEDT2L5N5ANCNFSM46KHUU7A .