search

microsoft / datamations

https://microsoft.github.io/datamations/
Other
67 stars 15 forks source link

Update gemini #77

Closed sharlagelfand closed 3 years ago

sharlagelfand commented 3 years ago

Looks like there have been some updates to gemini, including fixes for the weird sizing of axes / overlapping in firefox that I mentioned here (discussed in https://github.com/uwdata/gemini/issues/9)

@giorgi-ghviniashvili just want to check if you have added anything custom to gemini on your end that might be missed in this PR? I haven't updated my version of gemini in a while (just been pulling your latest JS code)

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand no, I have not added anything to gemini, but just to be sure, let's use this gemini: https://github.com/microsoft/datamations/blob/gio/infogrids/sandbox/app/libs/gemini.web.js

sharlagelfand commented 3 years ago

@giorgi-ghviniashvili that version is ~2 months old, the newest one is about a week old and that's when the sizing improvements I mentioned were added so they would be missed if we use the older version

giorgi-ghviniashvili commented 3 years ago

@sharlagelfand ah ok, then let's use the latest one you have.