search

microsoft / dbt-fabric

MIT License
79 stars 28 forks source link

Update depencency for dbt-common #142

Closed ChenyuLInx closed 8 months ago

amychen1776 commented 8 months ago

@prdpsvs can you assist on this? It's a blocker for us to support versionless.

prdpsvs commented 8 months ago

@amychen1776 , There seems to be additional permissions to be given on the pipeline. I am looking into additional permissions. For now, @ChenyuLInx , please do not fork and create a local branch and create a pull request?

ChenyuLInx commented 8 months ago

@prdpsvs I don't think I can do that since I am an outside contributor, do you mind just do this change and do an 1.8 rc release?

ChenyuLInx commented 8 months ago

@prdpsvs bumping this again for visibility. It might be easier if you can just make the change and release a new RC version. Thanks!!!!

prdpsvs commented 8 months ago

@ChenyuLInx , https://github.com/microsoft/dbt-fabric/invitations I sent you an invitation. You have permissions to create a PR on this repo. Do let me know as soon as your change is available. I will approve. I am busy with other priorities and unfortunately cannot open PR until day after tomorrow.

ChenyuLInx commented 8 months ago

@prdpsvs Thanks for the update! I tried to clone and push a branch to this repo from local and got

ERROR: Permission to microsoft/dbt-fabric.git denied to ChenyuLInx. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

And Tried to create another PR here, looks like checks are failing the same way

prdpsvs commented 8 months ago

@ChenyuLInx I have merged the other PR. Please use that. I will abandon this PR and close this one.