search

microsoft / dbt-fabric

MIT License
79 stars 28 forks source link

Hard coded references to fabric__create_table_as #183

Closed ms32035 closed 5 months ago

ms32035 commented 5 months ago

For example here: https://github.com/microsoft/dbt-fabric/blob/main/dbt/include/fabric/macros/materializations/models/incremental/incremental.sql#L34 we should be doing adapter.create_table_as. The current code breaks things downstream in dbt-sqlserver

prdpsvs commented 5 months ago

@ms32035 , this being handled in dbt-fabric 1.8.6 PR #178 I am fixing such downstream issues that might happen in dbt-synapse. Do add more if you find any. I will release the minor patch tomorrow.

prdpsvs commented 5 months ago

@ms32035 , hard coded references are removed except for tests helper. Synapse adapter will have its own version of tests helper. Please review v1.8.6 release and let me know. I am closing this issue at this time but feel free to share any other hard coded references.