search

microsoft / dbt-fabric

MIT License
79 stars 28 forks source link

`render_limited` should be an instance method not a class method #222

Closed cody-scott closed 2 months ago

cody-scott commented 2 months ago

https://github.com/microsoft/dbt-fabric/blob/46bb72f571f8db2ce35a460d85731b62f1f1dea7/dbt/adapters/fabric/fabric_relation.py#L20

I believe this should not be a class method but an instance method. It was the source of a number of errors when we were updating the sql server adapter so we switched it to instance. Instance is also how its defined in the base adapter.

https://github.com/dbt-labs/dbt-adapters/blob/c707b534184a1a631e9b27437b4737626e19a5bd/dbt/adapters/base/relation.py#L219