search

microsoft / dbt-fabric

MIT License
79 stars 28 forks source link

1.5 PR #54

Closed prdpsvs closed 1 year ago

prdpsvs commented 1 year ago

Updated dbt-tests-adapter version to 1.5.2 Updated dbt_version to 1.5 and dbt core dependency to 1.5.2 Updated adapter version to 1.5.0-rc1 Added constraint support to FabricAdapter class Added get_column_schema_from_query to test data type mapping. Remove get_column_schema_from_query post testing from FabricAdapter. Added data type mapping between pyodbc & SQL. Implemented data_type_code_to_name in Connection Manager class. Added 3 methods to columns.sql to assert model and constraints in yaml file. Added contact config check in create_table_As. use default__assert_columns_equivalent(). Added test_constraints to test the contract.

prdpsvs commented 1 year ago

just had a few nits and questions, but this looks great. really impressed with what you've been able to ship. hopefully you have a clear prioritized of TSQL API features that would make these features easier

Thanks Anders, I updated the PR based on your feedback. Could you please review?