microsoft / dbt-synapse

dbt adapter for Azure Synapse Dedicated SQL Pools
https://dbt-msft.github.io/dbt-msft-docs/docs/dbt-synapse/overview
MIT License
69 stars 29 forks source link

dbt-synapse `1.8.0rc1` broken by dbt-fabric `1.8.3` #242

Closed dataders closed 2 months ago

dataders commented 4 months ago

https://github.com/microsoft/dbt-fabric/pull/156 modified the below macros to include a USE [database], which is not compatible with Azure Synapse:

Because the latest dbt-synapse (1.8.0rc1) dependency is compatibility pinned (~=) to 1.8.0rc1, it auto-picks up any new patches to 1.8, including the latest 1.8.3 which includes the changes in https://github.com/microsoft/dbt-fabric/pull/156

https://github.com/microsoft/dbt-synapse/blob/8f4a6a3ab82ea20652bc162b0acbaee461702445/setup.py#L19

prdpsvs commented 3 months ago

@dataders , The synapse adapter has overrides for above macros in PR https://github.com/microsoft/dbt-synapse/pull/245/. Why are tests throwing the error - https://github.com/microsoft/dbt-synapse/actions/runs/9155466561/job/25168215613?

Did I miss something?

amychen1776 commented 2 months ago

@prdpsvs was this resolved?

prdpsvs commented 2 months ago

@amychen1776 , yes