search

microsoft / debug-adapter-protocol

Defines a common protocol for debug adapters.
https://microsoft.github.io/debug-adapter-protocol/
Other
1.41k stars 129 forks source link

DataBreakpointEvent? #30

Open hoehrmann opened 5 years ago

hoehrmann commented 5 years ago

I might be missing something here, but the Breakpoint type is for »Information about a Breakpoint created in setBreakpoints or setFunctionBreakpoints« while DataBreakpoint is for »Properties of a data breakpoint passed to the setDataBreakpoints request« and the BreakpointEvent is only for Breakpoint breakpoints. So it does not make sense to use BreakpointEvent for a change in a DataBreakpoint.

There is no DataBreakpointEvent. Is that an accidental omission?

I might want to create a data breakpoint based on a launch.json configuration option and inform vscode about it, so users can disable the breakpoint if they so choose (or for that matter, users might configure data breakpoints through the debug console instead of the vscode ui, and then I might also want to surface such breakpoints through vscode anyways).

yannickowow commented 3 years ago

Hi, I am facing the same thing here. Same issue appears as well between Breakpoint and FunctionBreakpoint, so we can't distinguish a new Breakpoint when sending this event. I guess it'll be similar with InstructionBreakpoint.

jreineckearm commented 1 year ago

Hi, we are hitting a similar problem for a debugger that offers console commands to manage breakpoints, including data breakpoints. For data breakpoints we cannot make the UI aware of changes driven by the console.