microsoft / debug-adapter-protocol

Defines a common protocol for debug adapters.
https://microsoft.github.io/debug-adapter-protocol/
Other
1.4k stars 128 forks source link

Support nesting of threads #339

Open firelizzard18 opened 1 year ago

firelizzard18 commented 1 year ago

I propose adding a property to Thread that a debug adapter can use to specify a parent-child relationship between threads. If thread 1 is the parent of thread 2, the development environment may choose to display thread 2 as a child of thread 1.

interface Thread {
  /**
   * Identifier of the thread's parent thread.
   */
  parentId?: number;
}

Motivation

Go uses green threads, called goroutines. A Go release in the near future will provide information from the debugger than can be used to determine a parent-child relationship between goroutines. Complex servers may have hundreds or thousands of goroutines. Debugging such a server can be challenging, especially when attempting to hunt down what caused a goroutine to be launched. I want Go's debug adapter, DAP, and VSCode to be updated to provide me the option of nesting goroutines to both make the call stack panel more manageable and make it easier to track down the ultimate cause of an event.

connor4312 commented 1 year ago

I think this makes sense as proposed.