[build] Drop Use of Unstable Features

microsoft / demikernel

Kernel-Bypass LibOS Architecture

https://aka.ms/demikernel

MIT License

898 stars 118 forks source link

[build] Drop Use of Unstable Features #172

Open ppenna opened 2 years ago

ppenna commented 2 years ago

Description

We currently rely on the following unstable features:

[ ] test: mainly used for feature microbenchmarks
[ ] allocator_api: used for implementing WakerPageRef
[ ] new_uninit
[ ] atomic_from_mut
[ ] never_type
[ ] type_alias_impl_trait
[ ] slice_ptr_get
[ ] strict_provenance

Expected Behavior

We should not rely on unstable features at all.

BrianZill commented 1 year ago

Pedro, where does this list come from? As I write this, there are 10 more optional "features" listed in lib.rs, is there an automatic way to determine if they are unstable or not? Many of these others are listed in The Unstable Book. Does that mean that they should be listed here as well?

ppenna commented 1 year ago

@BrianZill thanks for checking this.

This list comes from the features that we list in the lib.rs, thus yes you are correct we are missing some here. This issues was transferred from the old scheduler repository, and after that I have not updated it. I'm opening now a PR which gets rid of unused features, as well as I am updating the description of the issue here.

ppenna commented 1 year ago

Assigning all engineers to this issue, because it is critical.