search

microsoft / deoptexplorer-vscode

A VS Code extension to visualize deoptimizations in your JavaScript and TypeScript code running in V8 (i.e., NodeJS, Edge, Chrome, etc.).
MIT License
754 stars 9 forks source link

Support sourcemaps? #9

Closed ntucker closed 1 year ago

ntucker commented 1 year ago

I compile my benchmarks with webpack so it does all the normal optimizations I expect; but that means when I click the file it cannot find it

rbuckton commented 1 year ago

Is it possible the source file not exist at the path pointed to by the source map? Alternatively, does your source map contain embedded sources?

If you have a public project I could use to generate a repro, that would help to narrow down the cause.

rbuckton commented 1 year ago

I should add, Deopt Explorer does support source maps but we've had a few reports of source-map related issues that we're looking into.

ntucker commented 1 year ago

Ah, I didn't even realize it got the filenames wrong. For reference https://github.com/data-client/rest-hooks is the repo. The folder is /examples/benchmark with script 'start:deopt'.

I gotta look into webpack sourcemap control for monorepos...

Setup instructions for those interested in looking at the repo:

1) corepack enable 1) yarn install 1) yarn build 1) cd examples/benchmark 1) yarn build 1) yarn start:deopt

ntucker commented 1 year ago

Well now the logs won't load...no error message just infinite loading. I'll open a new issue for that