microsoft / design-to-code

A system of development tools, and utilities used à la carte or as a suite to build enterprise-grade websites and applications.
MIT License
24 stars 6 forks source link

Fix line number and column number which should start at 1 #105

Closed janechu closed 3 years ago

janechu commented 3 years ago

Pull Request

📖 Description

An assumption was made that line number and column number start at 0, this is incorrect as both start at 1. This PR updates the code to reflect this.

🎫 Issues

Related to #53

👩‍💻 Reviewer Notes

Check the tests for accuracy, the dictionary ID should be identified once past the "<" of the HTML tag it refers to, otherwise it should revert to the parent. Additionally the position should be updated for the line number and column change as stated in the description above.

✅ Checklist

General