search

microsoft / design-to-code

A system of development tools, and utilities used à la carte or as a suite to build enterprise-grade websites and applications.
MIT License
24 stars 6 forks source link

Remove the postinstall script as it causes errors during installation as a dependency #129

Closed janechu closed 3 years ago

janechu commented 3 years ago

Pull Request

📖 Description

The postinstall script is firing when the fast-tooling-react package is added as a dependency. To prevent this only the prepare script is utilized. It is unknown at this time why the change was made during migration.

Edit: well apparently it was because fast-tooling-react installs first even though fast-tooling is a dependency. Still looking for a solution.

👩‍💻 Reviewer Notes

Run installation locally to see if any issues arise.

✅ Checklist

General

janechu commented 3 years ago

Seems to be a few other things mixed into this PR as well. Was that intentional?

I'm testing a few things to fix the original issue, npm 7 workspaces and typescript are not playing well when it comes to completing installation of a symlinked dependency which is why the original change to the scripts was made during migration. The update to 4.3.x as I was hoping there would be a fix in there by using the paths to resolve the symlinked files however that's not the case as the problem is a matter of the order in which packages are built, so I'll revert those changes once I verify my solution is working.

janechu commented 3 years ago

@EisenbergEffect PR updated, this should be a fairly straightforward change now.