[Bug] Incorrect ARIA for Navigation Menu Items in fast-tooling

microsoft / design-to-code

A system of development tools, and utilities used à la carte or as a suite to build enterprise-grade websites and applications.

MIT License

24 stars 6 forks source link

[Bug] Incorrect ARIA for Navigation Menu Items in fast-tooling #6

Closed chrisdholt closed 3 years ago

chrisdholt commented 3 years ago

The following bug was found during an automated accessibility scan using Accessibility Insights for web.

aria-valid-attr-value: Ensures all ARIA attributes have valid values Navigation Menu Items include an attribute of aria-controls which is pointing to an ID which does not exist.

What behavior did you expect? aria-controls is used only when needed and correlates to an ID on the document.

janechu commented 3 years ago

Closing in favor of deprecating the Navigation Menu, see https://github.com/microsoft/fast/issues/4501 and https://github.com/microsoft/fast-tooling/issues/55