Closed janechu closed 3 years ago
Is there any way we can get rid of Babel?
@EisenbergEffect I was able to remove babel from @microsoft/fast-tooling
however it's needed in @microsoft/fast-tooling-react
because jest needs it for transforms, ts-jest
will convert from .ts
and .tsx
to .js
and .jsx
respectively, but babel-jest
is needed to further convert the .jsx
and esm
.js
for jest
consumption.
Jest. Sigh. Ok 😭 Maybe we'll get around to addressing that some day but yeah let's not worry about it for now. Thanks Jane!
Pull Request
📖 Description
This pull request adds the
@microsoft/fast-tooling
,@microsoft/fast-tooling-react
, and@microsoft/fast-tooling-wasm
packages to the repository using NPM 7 workspaces.This should allow:
npm run test
from the package root to run all testsfast-tooling
andfast-tooling-react
packages runningnpm start
to kick off a build of thewebpack-dev-server
👩💻 Reviewer Notes
Pull down the repository, use
npm i
ornpm install
to install dependencies, then usenpm run test
at the root andnpm start
in thefast-tooling
andfast-tooling-react
packages.Keep in mind that the requirements for this repository are now NPM 7 and NodeJS 16, ensure these are both installed.
✅ Checklist
General