Closed jessetrinity closed 2 years ago
Were you planning to remove the Name == "Microsoft.DevTunnels.Ssh"
check from IsVsSsh()
?
Were you planning to remove the
Name == "Microsoft.DevTunnels.Ssh"
check fromIsVsSsh()
?
Won't that cause issues with the (few) already published versions using that name?
Won't that cause issues with the (few) already published versions using that name?
Yes.
This is a followup to the ssh version check change that was done when open sourcing the library. This allows us to not rely on the version name for the port switching behavior.
can-change-port
extension to indicate whether the ssh implementation supports changing ports.isVsSsh
check (which does this same thing) should be retained for older versions of the library which don't support the extension.isVsSsh
check where it is no longer needed (for versions2.x
).