microsoft / dev-tunnels-ssh

SSH library for dev-tunnels
MIT License
131 stars 17 forks source link

Add can-change-port extension #11

Closed jessetrinity closed 2 years ago

jessetrinity commented 2 years ago

This is a followup to the ssh version check change that was done when open sourcing the library. This allows us to not rely on the version name for the port switching behavior.

jasongin commented 2 years ago

Were you planning to remove the Name == "Microsoft.DevTunnels.Ssh" check from IsVsSsh()?

jessetrinity commented 2 years ago

Were you planning to remove the Name == "Microsoft.DevTunnels.Ssh" check from IsVsSsh()?

Won't that cause issues with the (few) already published versions using that name?

jasongin commented 2 years ago

Won't that cause issues with the (few) already published versions using that name?

Yes.