search

microsoft / dev-tunnels-ssh

SSH library for dev-tunnels
MIT License
131 stars 17 forks source link

Make channel open response messages extensible #42

Closed jasongin closed 1 year ago

jasongin commented 1 year ago

With this change, handlers of the SshSession.ChannelOpening event can (asynchronously) return an instance of a subclass of ChannelOpenConfirmationMessage or ChannelOpenFailureMessage to supply additional information with the response.

This kind of extensibility was already supported for session request and response messages, and channel request messages, so this fills in the gap for channel response messages.

IlyaBiryukov commented 1 year ago

Should this be a major version bump because of the breaking changes?

jasongin commented 1 year ago

Should this be a major version bump because of the breaking changes?

I haven't been that strict about following semver rules with this library. This change only affects a more advanced API that is only used by our team as far as I know.