microsoft / devhome

The new Dev Home experience for Windows!
https://aka.ms/devhomedocs
MIT License
3.62k stars 322 forks source link

Environments Launch splitbutton arrow shows empty flyout for compute systems with no alternative launch options #2574

Closed nieubank closed 1 month ago

nieubank commented 6 months ago

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Install a compute system extension that only supports launch and no other operations.

see

        <DataTemplate x:Key="LaunchButton" x:DataType="vm:ComputeSystemViewModel">
            <SplitButton
                    VerticalAlignment="Top"
                    Command="{x:Bind LaunchActionCommand}"
                    x:Uid="ms-resource:///DevHome.Environments/Resources/LaunchButton"
                    Style="{StaticResource CardBodySplitButtonStyle}">
                <SplitButton.Flyout>
                    <customControls:CardFlyout ItemsViewModels="{x:Bind LaunchOperations}"/>
                </SplitButton.Flyout>
            </SplitButton>
        </DataTemplate>

Expected result

The split button arrow should not appear (or at least be disabled?).

Actual result

The split button arrow can be clicked resulting in an empty flyout.

image

Included System Information

No response

Included Extensions Information

No response

huzaifa-d commented 2 months ago

@hamza-usmani this is a P3, since this involves using an extension that only supports launch, i.e. - theoretical.

huzaifa-d commented 1 month ago

Fixed in #3365