microsoft / devhome

The new Dev Home experience for Windows!
https://aka.ms/devhomedocs
MIT License
3.56k stars 310 forks source link

File Explorer Integration no errors on failure. #3609

Closed dhoehna closed 1 week ago

dhoehna commented 1 month ago

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Enable File Explorer Integration. Go to Windows customization > File Explorer. Click "Add Folder" Add a repo that has dubious ownership. Click the drop down. Click "git"

Expected result

A content dialog, or an error message, telling me why I can't attach the git extension to the repo.

Actual result

The combo box stays on "Unassigned" and does not show an error message.

Included System Information

No response

Included Extensions Information

No response

DefaultRyan commented 1 month ago

Thanks! @ssparach has already been looking into this. Was this the result of adding a WSL repo?

DefaultRyan commented 1 month ago

@dhoehna is this a duplicate of #3610 ?

microsoft-github-policy-service[bot] commented 1 month ago

We've identified this as a duplicate of another one that already exists. This specific instance is being closed in favor of tracking the concern over on the the linked issue. Please add your 👍 to the other issue to raise its priority. Thanks for your report!

adrastogi commented 4 weeks ago

I think I tripped over this by picking a folder that didn't have a git repository in it (I picked the parent folder by mistake). The logs tipped me off, but having the UX tell me this would be nice.

[2024/08/16 09:37:22.832 INF] (SourceControlIntegration) Validating source control extension with arguments: extensionCLSID = A65E46FF-F979-480d-A379-1FDA3EB5F7C5, rootPath = D:\src
[2024/08/16 09:37:23.795 ERR] (SourceControlIntegration) Could not open local repository.
[2024/08/16 09:37:23.795 ERR] (SourceControlIntegration) Unable to get repository at the given root path
[2024/08/16 09:37:23.797 ERR] (FileExplorerViewModel) Failed to validate source control extension